Skip to content

feat: update licensing pills to reflect new premium tier #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

feat: update licensing pills to reflect new premium tier #14670

merged 2 commits into from
Sep 13, 2024
+182 −66

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Sep 13, 2024 •
edited
Loading

resolves #14657

  • Remove all entitled badges from the UI
  • Display Enterprise Badge for user with enterprise license for observability and appearance without showing a popover paywall tooltip.
  • Display Premium Badge for observability and appearance when the user has a premium license or no license. Display a popover paywall tooltip describing the feature.
  • Display a premium Badge for org creation if the user has a premium license and show a popover paywall tooltip.

@jaaydenh jaaydenh self-assigned this Sep 13, 2024
@jaaydenh jaaydenh changed the title Jaaydenh/premium pills feat: update licensing pills to reflect new premium tier Sep 13, 2024
@jaaydenh jaaydenh changed the base branch from main to jaayden/create-org-premium September 13, 2024 15:56
@Parkreiner
Copy link
Member

Extension of #14650

@aslilac
Copy link
Member

aslilac commented Sep 13, 2024

I think some of the pills look a little weird being all by themselves, maybe we could move them onto the header lines when possible?

@jaaydenh
Copy link
Contributor Author

@aslilac @chrifro Christin created a new design here for the beta label, https://www.figma.com/design/1bHJvrhzQNLnDqT3WRgqzn/organizations?node-id=0-1&t=ejGVc9VouNMkvmI5-1

So its looking like it makes more sense to keep the enterprise/premium badge where it is for now instead of moving it next to the new beta label.

aslilac
aslilac approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we can punt on that then

@jaaydenh jaaydenh merged commit 09a92cb into jaayden/create-org-premium Sep 13, 2024
27 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/premium-pills branch September 13, 2024 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@Parkreiner Parkreiner Awaiting requested review from Parkreiner

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: update licensing pills to reflect new premium tier
3 participants
@jaaydenh @Parkreiner @aslilac