chore: improve coder server ux
#14761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
bf8650d to
0dc2a89
Compare
ethanndickson
commented
Sep 23, 2024
deansheather
approved these changes
Sep 23, 2024
0dc2a89 to
c628077
Compare
|
Looks clean. Thank you. |
sreya
approved these changes
Sep 23, 2024
|
@ethanndickson heads up: this seems to open the access URL even if it's a slim build (and therefore has no UI bundled). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#54.
Currently,
coder serverdoesn't take any steps to ensure the access URL it outputs stands out among the initial stream of logs.To address this, this PR:
Wraps the access URL in a colourful box (ANSI bright blue (12) box, ANSI magenta (5) hyperlink)
Opens the access URL in the default browser, if the
BROWSERenv var is set, and if outputting to a TTY. Can be disabled using--no-open. This is the same behaviour ascoder login.Improves the naming of some loggers, as some logs were previously duplicated with no indication as to why.
Changes some startup logs from
infotodebugThe full startup output is now:
I'd argue the remaining
infolevel logs are appropriate, I think something like how many provisioners are running, and what terraform version they're running are worth outputting by default, but very much open to thoughts.