Skip to content

fix: use latest build version name on workspace page #14771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: use latest build version name on workspace page #14771

merged 1 commit into from
Sep 23, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 23, 2024 •
edited
Loading

Closes #14763

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson added the hotfix PRs only. Harmless small change. Only humans may set this. label Sep 23, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Sep 23, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson marked this pull request as ready for review September 23, 2024 12:57
@ethanndickson ethanndickson enabled auto-merge (squash) September 23, 2024 12:57
@ethanndickson ethanndickson merged commit b4f54f3 into main Sep 23, 2024
35 checks passed
@ethanndickson ethanndickson deleted the 09-23-fix_use_latest_build_version_name_on_workspace_page branch September 23, 2024 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
@matifali
Copy link
Member

@stirby We may need to patch 2.15.0 with this. I have not tested but I believe it exists on that branch.

@ethanndickson
Copy link
Member Author

ethanndickson commented Sep 23, 2024 •
edited
Loading

2.15 should be fine:

coder/site/src/pages/WorkspacePage/WorkspaceTopbar.tsx

Line 183 in 190cd1c

to={`${templateLink}/versions/${workspace.latest_build.template_version_name}`}

@matifali
Copy link
Member

Yes, I just confirmed. It happened after #14596 which is not included in 2.15.0 yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@ethanndickson ethanndickson

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid template version path in dashboard on the workspace page.
2 participants
@ethanndickson @matifali