chore: add site flag to buildinfo
#14868
Merged
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
site flag to buildinfo
dannykopping
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
LGTM, thanks for addressing this.
Side-note: coder/internal#54 (which you addressed in the previous PR) says to only open the browser on the first run. This happens on every run currently, and I think we ought to mention how to disable this.
Perhaps like this?
╔═══════════════════════════════════════════════╗
║ View the Web UI: ║
║ https://et23ntkhpueak.pit-1.try.coder.app ║
║ Disable auto-open with `--no-open` ║
╚═══════════════════════════════════════════════╝
Or only do so when the first user has not been created?
|
The database doesn't get initialised until a fair bit after we print the access URL, after which a bunch of logs will have streamed in. |
03ac0f8 to
7fa8132
Compare
7fa8132 to
9075bf9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #14761, the access URL is automatically opened in the browser when running
coder server. This becomes annoying when running versions of Coder without a frontend during development.This PR skips opening the URL in the browser when there is no frontend embedded into the binary. Since this is different from a
slimbuild of Coder (i.e. a true slim build is ~40mb, this build is ~120mb), it wouldn't make sense to set the existingslimflag to true. The solution is to add a newsiteflag, and ahasSitefunction tobuildinfothat can be used to detect frontendless builds.