chore(cli): rename build options to ephemeral parameters in cli #15030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emeral-param' into chore/rename-build-option-to-ephemeral-param
| ephemeral parameters to model specific behaviors in a Coder workspace, such as | ||
| reverting to a previous image, restoring from a volume snapshot, or building a | ||
| project without using cache. | ||
| Ephemeral parameters are introduced to users in order to model specific behaviors |
There was a problem hiding this comment.
@EdwardAngert would you mind weighing in on this?
There was a problem hiding this comment.
Thanks, definitely up for some help here.
The main point @EdwardAngert is that I'd like to remove anything related to build_options. For the rest, really keen for some help but nothing has changed per itself in the logic.
mafredri
reviewed
Oct 12, 2024
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
|
Thanks @mafredri - your suggestions improved the usage of it. Just waiting for some feedback in the documentation, but all good for me otherwise. |
EdwardAngert
approved these changes
Oct 14, 2024
…to-ephemeral-param
|
incoming commit to try to fix some 404 errors and appease the CI |
|
Just fixed the CI here - logic and test side should be good - just waiting for a last review from @EdwardAngert as now the CI is happy and it will simplify changes. |
dannykopping
approved these changes
Oct 16, 2024
EdwardAngert
approved these changes
Oct 16, 2024
dannykopping
approved these changes
Oct 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to rename
build-optiontoephemeral-parametersbased on #10488 conversation.build-optionhas been renamedephemeral-parameterand can be used to define a value for an ephemeral parameter in the template.build-optionshas been renamedprompt-ephemeral-parametersand can be used to prompt the user to put values for the ephemeral parameters in the template.