Skip to content

fix(coderd/notifications): exclude unset fields from notifications #15110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix(coderd/notifications): exclude unset fields from notifications #15110

merged 1 commit into from
Oct 16, 2024

Conversation

SasSwart
Copy link
Contributor

This PR will ensure that optional fields are ignored when they are unset in user account related templates.

@SasSwart SasSwart requested a review from dannykopping October 16, 2024 18:39
dannykopping
dannykopping approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SasSwart
Copy link
Contributor Author

Tested using Mailhog:

image
image
image
image

@SasSwart SasSwart merged commit dfb6bfa into main Oct 16, 2024
27 checks passed
@SasSwart SasSwart deleted the jjs/notifications branch October 16, 2024 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

@SasSwart SasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasSwart @dannykopping