fix: check unstaged files during ci lint #15120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
4b3a9a3 to
4c34304
Compare
4c34304 to
7b51225
Compare
ethanndickson
commented
Oct 17, 2024
| @@ -223,6 +223,12 @@ jobs: | |||
| ./actionlint -color -shellcheck= -ignore "set-output" | |||
| shell: bash | |||
|
|
|||
| - name: Check for unstaged files | |||
| run: | | |||
| rm -f ./actionlint ./typos | |||
There was a problem hiding this comment.
The typos action we use doesn't let you modify the binary install directory to anything other than the current directory (Is there a good reason why?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint runmakes changes to files for trivial lints, such as import ordering, but CI doesn't currently check for these changes like it does forfmtandgen. It might be possible to havegolangci-lintreturn an error when it makes a change, but that would only be for Go, and it seems sensible to have it be language agnostic.There's perhaps an argument to be made (at least in my head) that
lintshouldn't be making changes, only raising warnings/errors, but that's not whatgolangci-linthas decided.