Skip to content

fix: check unstaged files during ci lint #15120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: check unstaged files during ci lint #15120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,12 @@ jobs:
./actionlint -color -shellcheck= -ignore "set-output"
shell: bash

- name: Check for unstaged files
run: |
rm -f ./actionlint ./typos
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typos action we use doesn't let you modify the binary install directory to anything other than the current directory (Is there a good reason why?)

./scripts/check_unstaged.sh
shell: bash

gen:
timeout-minutes: 8
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
Expand Down
2 changes: 1 addition & 1 deletion coderd/activitybump_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func TestWorkspaceActivityBump(t *testing.T) {
}

// maxTimeDrift is how long we are willing wait for a deadline to
// be increased. Since it could have been bumped at the intial
// be increased. Since it could have been bumped at the initial
maxTimeDrift := testutil.WaitMedium

updatedAfter := dbtime.Now()
Expand Down
3 changes: 2 additions & 1 deletion enterprise/wsproxy/keyfetcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@ package wsproxy
import (
"context"

"golang.org/x/xerrors"

"github.com/coder/coder/v2/coderd/cryptokeys"
"github.com/coder/coder/v2/codersdk"
"github.com/coder/coder/v2/enterprise/wsproxy/wsproxysdk"
"golang.org/x/xerrors"
)

var _ cryptokeys.Fetcher = &ProxyFetcher{}
Expand Down
Loading