fix: include custom agent headers in tailnet to support DERP connections #15145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
|
|
b09f08f to
eb5a0d9
Compare
spikecurtis
approved these changes
Oct 21, 2024
|
|
||
| // We set the handler after server creation for the access URL. | ||
| coderAPI := coderd.New(newOptions) | ||
| setHandler(coderAPI.RootHandler) |
There was a problem hiding this comment.
What's the purpose of setting this handler --- isn't that already the handler the API will use?
There was a problem hiding this comment.
Not in this case, calling NewWithAPI normally sets the handler to coderAPI.RootHandler.
setHandler, cancelFunc, serverURL, newOptions := NewOptions(t, options)
// We set the handler after server creation for the access URL.
coderAPI := coderd.New(newOptions)
setHandler(coderAPI.RootHandler)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15131.
I introduced a
CODER_AGENT_HEADERoption for supplying extra headers for the agent, but these headers weren't included when communicating with DERP relays. This PR plumbs them intotailnet.NewConnas required.