Skip to content

example: add docker-image-builds + docker docs #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 18, 2022
Merged

example: add docker-image-builds + docker docs #1526

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f7b22ea
move docker-local to docker
bpmct May 17, 2022
21c224f
example: add docker-image-builds + docker docs
bpmct May 17, 2022
3b609fc
fix bug
bpmct May 17, 2022
6bacbc8
fix a versioning bug
bpmct May 17, 2022
e2d007b
use node 14, like readme
bpmct May 17, 2022
36679ec
Merge branch 'main' into bpmct/add-docker-builds
bpmct May 17, 2022
89d462e
fixes from review
bpmct May 17, 2022
3c841e5
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
f47b38a
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
6f02c13
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
64c39ea
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
1e51794
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
272dfe2
Update examples/docker/README.md
bpmct May 18, 2022
601d664
Update examples/docker/README.md
bpmct May 18, 2022
759bc06
Update examples/docker/README.md
bpmct May 18, 2022
64707af
Update examples/docker/main.tf
bpmct May 18, 2022
0dd31fc
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
6b2dbe9
Update examples/docker-image-builds/README.md
bpmct May 18, 2022
a747cec
fixes from feedback
bpmct May 18, 2022
30136fc
Merge branch 'main' into bpmct/add-docker-builds
bpmct May 18, 2022
cd4da31
Revert "Merge branch 'main' into bpmct/add-docker-builds"
bpmct May 18, 2022
bd16739
Merge branch 'main' into bpmct/add-docker-builds
bpmct May 18, 2022
13cdff5
restore docker warning
bpmct May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update examples/docker-image-builds/README.md 
Co-authored-by: Katie Horne <katie@23spoons.com>
  • Loading branch information
@bpmct @khorne3
bpmct and khorne3 authored May 18, 2022
commit 6f02c132c9ef14ce531c6afe02845d16f0d0d4eb
2 changes: 1 addition & 1 deletion examples/docker-image-builds/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ tags: [local, docker]

This example bundles Dockerfiles with the Coder template, allowing the Docker host to build images itself instead of relying on an external registry.

For large use cases, we recommend building images using CI/CD pipelines and registries instead of at workspace "runtime." However, this example is practical for tinkering and iterating on Dockerfiles.
For large use cases, we recommend building images using CI/CD pipelines and registries instead of at workspace runtime. However, this example is practical for tinkering and iterating on Dockerfiles.

## Getting started

Expand Down