Skip to content

example: add docker-image-builds + docker docs #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 18, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes from review
  • Loading branch information
bpmct committed May 17, 2022
commit 89d462e0bb7cf5040a2cb49256dfa986df7c346c
2 changes: 1 addition & 1 deletion examples/docker-image-builds/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FROM coder-base:latest
USER root

# Install go
RUN curl -L "https://dl.google.com/go/go1.17.1.linux-amd64.tar.gz" | tar -C /usr/local -xzvf -
RUN curl -L "https://dl.google.com/go/go1.18.1.linux-amd64.tar.gz" | tar -C /usr/local -xzvf -

# Setup go env vars
ENV GOROOT /usr/local/go
Expand Down
2 changes: 1 addition & 1 deletion examples/docker-image-builds/images/base.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ RUN useradd coder \
--user-group && \
echo "coder ALL=(ALL) NOPASSWD:ALL" >>/etc/sudoers.d/nopasswd

USER coder
USER coder
5 changes: 0 additions & 5 deletions examples/docker/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,6 @@ variable "docker_image" {
error_message = "Invalid Docker Image!"
}

validation {
condition = contains(["codercom/enterprise-base:ubuntu", "codercom/enterprise-node:ubuntu", "codercom/enterprise-intellij:ubuntu"], var.docker_image)
error_message = "Invalid Docker Image!"
}

}

resource "docker_volume" "home_volume" {
Expand Down