fix(site): show error on duplicate template rename attempt #15348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
3e07a6c to
35b9beb
Compare
35b9beb to
6755b76
Compare
ethanndickson
commented
Nov 4, 2024
coderd/templates.go
Outdated
| httpapi.InternalServerError(rw, err) | ||
| if database.IsUniqueViolation(err) { | ||
| httpapi.Write(ctx, rw, http.StatusConflict, codersdk.Response{ | ||
| Message: fmt.Sprintf("Template %q already exists.", req.Name), |
There was a problem hiding this comment.
Definitely out of scope of this PR, but we should develop some centralised mapping of database violations to human readable error messages (codersdk.Response?).
6755b76 to
e54c6a2
Compare
|
@ethanndickson the PR looks good but I'm missing tests for FE and BE |
e54c6a2 to
f05ef70
Compare
ethanndickson
commented
Nov 5, 2024
Comment on lines
+619
to
+621
| if !dbtestutil.WillUsePostgres() { | ||
| t.Skip("This test requires Postgres constraints") | ||
| } |
There was a problem hiding this comment.
dbmem is getting removed in the near future, where this'll get removed too.
f05ef70 to
f277a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15311.