-
Notifications
You must be signed in to change notification settings - Fork 875
feat: implement CRUD UI for IDP organization sync settings #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
d0baa8c
feat: initial commit for idp org sync settings
jaaydenh 6463076
feat: add export policy button
jaaydenh f714986
feat: update badge styles for multiple selector
jaaydenh 072d775
feat: use input component and move export button
jaaydenh f6e286c
feat: add delete button for org mapping
jaaydenh acf8cbe
feat: disabled button states
jaaydenh ad1aa84
feat: update export policy button to shadcn
jaaydenh b01588d
fix: fix format
jaaydenh 6203d04
feat: display success/error toast on form submission
jaaydenh bc37998
feat: create story for export policy button
jaaydenh 2c2246d
feat: update pill list component
jaaydenh 6971f91
feat: add down chevron to multiple selector
jaaydenh 6e87130
chore: update conventions for shadcn components
jaaydenh a1b6e79
feat: use semantic list html for overflow pills
jaaydenh 36c8706
chore: update css variable colors
jaaydenh a4e66c2
fix: make link style and behavior match existing links
jaaydenh f7be49f
fix: use display name for org in multi-select component
jaaydenh 90a65fe
chore: cleanup
jaaydenh c282765
fix: styling for x and chevron buttons
jaaydenh 40155bc
chore: extract fixed filter options to a variable
jaaydenh a129820
fix: update focus styles
jaaydenh 8edd4b4
fix: multi-select placement fix
jaaydenh e54e5ca
fix: improve export policy button logic
jaaydenh bb16bd1
chore: update to use pointer instead of mouse events
jaaydenh 678a91d
fix: extract UUID testing to separate variable
jaaydenh a13d9b2
fix: update error handling
jaaydenh 1b8efd1
chore: add source comment
jaaydenh 137c25c
chore: remove debounce
jaaydenh 46a4646
fix: format
jaaydenh 85a455c
feat: update form save logic
jaaydenh a9e06f1
fix: remove popover and muted colors from shadcn
jaaydenh d921b08
chore: cleanup
jaaydenh ba665b4
fix: use form instead of sync settings for state
jaaydenh 8a0e789
chore: fix component filename casing
jaaydenh 234c0fb
fix: dont await form.setFieldValue
jaaydenh 7d88a38
feat: add radix visually hidden
jaaydenh c6c9b16
fix: improve focus styling
jaaydenh 5322a4e
chore: cleanup
jaaydenh eab8a0d
fix: format
jaaydenh 721d5d4
feat: updates for Badge component
jaaydenh 8986cbd
feat: updates for shadcn button component
jaaydenh 89a7b12
feat: update stories and input component
jaaydenh 148dca7
fix: format
jaaydenh 0c338b0
feat: add stories for switch component
jaaydenh 0cadc8b
feat: setup stories for Label component
jaaydenh 1d7153b
feat: setup stories for shadcn Dialog component
jaaydenh a914c54
fix: format
jaaydenh bd307c0
chore: make clasnames multi-line
jaaydenh 95bfd17
fix: use multiline classnames
jaaydenh 82bd850
fix: display blue outline on multiple selector when focused
jaaydenh 6eb6987
fix: format
jaaydenh 3822b2e
feat: add stories for MultiSelectCombobox
jaaydenh fe17b1c
feat: add tooltip for assign default org switch
jaaydenh e75e179
feat: add stories for IdpOrgSyncPageview
jaaydenh c6e07ff
chore: extract UUID regex
jaaydenh a3b9b27
chore: cleanup
jaaydenh 0601164
feat: add form validation schema
jaaydenh b01e5d3
fix: cleanup paywall copy
jaaydenh 1c5b6ef
fix: cleanup
jaaydenh 6e2ee08
fix: remove useEffect
jaaydenh ae30db0
chore: cleanup
jaaydenh ac74cdc
fix: format
jaaydenh a99dca5
chore: cleanup for PR review comments
jaaydenh 4c00959
fix: focus rings
jaaydenh 568a5a9
chore: use tailwinds sr-only class
jaaydenh c313439
fix: fix 2xs fontSize
jaaydenh 506223d
chore: convert UUID regex to a function
jaaydenh f223ab7
feat: add enabled check
jaaydenh 94ff4ca
chore: cleanup
jaaydenh 9101e0e
fix: fix format
jaaydenh 5ca2c0c
chore: cleanup
jaaydenh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: remove debounce
- Loading branch information
commit 137c25c759862890c7644b1a0ae644714f4e1ea9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to follow a specific style guide for our file names? Because I'm worried that our adoption of Shad right now is already causing inconsistencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a top-level comment linking to where the bulk of this code came from? That's going to make tracking down bugs a lot easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Parkreiner @aslilac Regarding file names, currently we have a mixture of camel case and pascal case and shadcn uses snake case by default. I personally think capitalizing file names can lead to more mistakes but I am fine with whatever we agree upon.