Skip to content

chore: run macOS, windows, and race tests with Postgres in CI #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 3, 2024
Merged

chore: run macOS, windows, and race tests with Postgres in CI #15520

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5686771
run pg tests on macos and windows in CI
hugodutka Nov 14, 2024
fede550
set default encoding on embedded pg
hugodutka Nov 14, 2024
cd9b4d1
allow test-go-pg to fail on windows
hugodutka Nov 15, 2024
e797183
add pg race test to ci
hugodutka Nov 15, 2024
fb23890
require test-go-race-pg to pass
hugodutka Nov 15, 2024
4e3421f
trigger ci
hugodutka Nov 15, 2024
46a8c60
remove the fail-fast: false strategy from test-go-pg
hugodutka Nov 15, 2024
dcfdc07
ensure we received results from all matrix jobs
hugodutka Nov 17, 2024
5d79aea
simplify the required check
hugodutka Nov 17, 2024
1c99f2e
runners fallback
hugodutka Nov 17, 2024
de40386
make the windows pg test required
hugodutka Nov 26, 2024
988c893
use a temporary folder on the D: drive in Windows CI for postgres
hugodutka Dec 2, 2024
e7463ec
test out imdisk (ramdisk) for windows
hugodutka Dec 2, 2024
b41c523
try fix
hugodutka Dec 2, 2024
8a61183
another fix
hugodutka Dec 2, 2024
d319138
fix
hugodutka Dec 2, 2024
c63786f
try ramdisk with postgres
hugodutka Dec 2, 2024
ed13154
create an action for setting up imdisk
hugodutka Dec 2, 2024
4b6f183
revert lint job changes
hugodutka Dec 2, 2024
9c7e240
clarity and grammar
hugodutka Dec 2, 2024
4969a23
fmt
hugodutka Dec 2, 2024
160e77c
remove empty inputs
hugodutka Dec 2, 2024
f87261f
add link to the StartParameters issue
hugodutka Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
runners fallback
  • Loading branch information
@hugodutka
hugodutka committed Dec 2, 2024
commit 1c99f2e5a0f46fc70f59cb3c3473f15e0e4dc9e4
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ jobs:
api-key: ${{ secrets.DATADOG_API_KEY }}

test-go-pg:
runs-on: ${{ matrix.os == 'ubuntu-latest' && github.repository_owner == 'coder' && 'depot-ubuntu-22.04-4' || matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'macos-latest-xlarge'}}
runs-on: ${{ matrix.os == 'ubuntu-latest' && github.repository_owner == 'coder' && 'depot-ubuntu-22.04-4' || matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'macos-latest-xlarge' || matrix.os }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy mother of github actions interpolation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have this on go-test 😭

needs: changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
Expand Down Expand Up @@ -442,7 +442,7 @@ jobs:
# temporarily allow windows tests to fail. Using a matrix strategy here makes
Copy link
Member

@ethanndickson ethanndickson Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Windows tests are broken, I'm not sure if we want to merge a CI suite that often fails, even if it's not required (could slightly obscure real issues + not great optics). Perhaps it should just get skipped/commented out until we're able to improve the reliability?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we do have the Windows tests covered by in memory for now, maybe these should be disabled for now to avoid ❌ appearing everywhere. Are there any issues tracking the windows tests breaking in postgres?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any issues tracking the windows tests breaking in postgres?

I just added #15560.

for now, maybe these should be disabled for now to avoid ❌ appearing everywhere

Makes sense. I'll postpone merging this PR until Windows tests are fixed. I'll try to get it done this week.

# the check in the `required` job rather complicated.
test-go-pg-windows:
runs-on: ${{ github.repository_owner == 'coder' && 'windows-latest-16-cores' }}
runs-on: ${{ github.repository_owner == 'coder' && 'windows-latest-16-cores' || 'windows-latest' }}
needs: changes
if: needs.changes.outputs.go == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
# This timeout must be greater than the timeout set by `go test` in
Expand Down