Skip to content

chore: run macOS, windows, and race tests with Postgres in CI #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 3, 2024
Merged

chore: run macOS, windows, and race tests with Postgres in CI #15520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5686771
run pg tests on macos and windows in CI
hugodutka Nov 14, 2024
fede550
set default encoding on embedded pg
hugodutka Nov 14, 2024
cd9b4d1
allow test-go-pg to fail on windows
hugodutka Nov 15, 2024
e797183
add pg race test to ci
hugodutka Nov 15, 2024
fb23890
require test-go-race-pg to pass
hugodutka Nov 15, 2024
4e3421f
trigger ci
hugodutka Nov 15, 2024
46a8c60
remove the fail-fast: false strategy from test-go-pg
hugodutka Nov 15, 2024
dcfdc07
ensure we received results from all matrix jobs
hugodutka Nov 17, 2024
5d79aea
simplify the required check
hugodutka Nov 17, 2024
1c99f2e
runners fallback
hugodutka Nov 17, 2024
de40386
make the windows pg test required
hugodutka Nov 26, 2024
988c893
use a temporary folder on the D: drive in Windows CI for postgres
hugodutka Dec 2, 2024
e7463ec
test out imdisk (ramdisk) for windows
hugodutka Dec 2, 2024
b41c523
try fix
hugodutka Dec 2, 2024
8a61183
another fix
hugodutka Dec 2, 2024
d319138
fix
hugodutka Dec 2, 2024
c63786f
try ramdisk with postgres
hugodutka Dec 2, 2024
ed13154
create an action for setting up imdisk
hugodutka Dec 2, 2024
4b6f183
revert lint job changes
hugodutka Dec 2, 2024
9c7e240
clarity and grammar
hugodutka Dec 2, 2024
4969a23
fmt
hugodutka Dec 2, 2024
160e77c
remove empty inputs
hugodutka Dec 2, 2024
f87261f
add link to the StartParameters issue
hugodutka Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use a temporary folder on the D: drive in Windows CI for postgres
  • Loading branch information
@hugodutka
hugodutka committed Dec 2, 2024
commit 988c8935a2101c42c23f6a720be3d161c956e0bc
6 changes: 6 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,12 @@ jobs:

if [ "${{ runner.os }}" == "Linux" ]; then
make test-postgres
elif [ "${{ runner.os }}" == "Windows" ]; then
# Create temp dir on D: drive for Windows. The default C: drive is extremely
# slow: https://github.com/actions/runner-images/issues/8755
mkdir -p "D:/temp/embedded-pg"
go run scripts/embedded-pg/main.go -path "D:/temp/embedded-pg"
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
else
go run scripts/embedded-pg/main.go
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
Expand Down
9 changes: 9 additions & 0 deletions scripts/embedded-pg/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,23 @@ package main

import (
"database/sql"
"flag"
"os"
"path/filepath"

embeddedpostgres "github.com/fergusstrange/embedded-postgres"
)

func main() {
var customPath string
flag.StringVar(&customPath, "path", "", "Optional custom path for postgres data directory")
flag.Parse()

postgresPath := filepath.Join(os.TempDir(), "coder-test-postgres")
if customPath != "" {
postgresPath = customPath
}

ep := embeddedpostgres.NewDatabase(
embeddedpostgres.DefaultConfig().
Version(embeddedpostgres.V16).
Expand Down