Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,17 @@ export const NavigateToStartStage: Story = {
await canvas.findByText("Startup Script");
},
};

// Test case for https://github.com/coder/coder/issues/15413
export const DuplicatedScriptTiming: Story = {
args: {
agentScriptTimings: [
WorkspaceTimingsResponse.agent_script_timings[0],
{
...WorkspaceTimingsResponse.agent_script_timings[0],
started_at: "2021-09-01T00:00:00Z",
ended_at: "2021-09-01T00:00:00Z",
},
],
},
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import {
agentStages,
provisioningStages,
} from "./StagesChart";
import sortBy from "lodash/sortBy";
import uniqBy from "lodash/uniqBy";

type TimingView =
| { name: "default" }
Expand All @@ -42,11 +44,20 @@ export const WorkspaceTimings: FC<WorkspaceTimingsProps> = ({
defaultIsOpen = false,
}) => {
const [view, setView] = useState<TimingView>({ name: "default" });
// This is a workaround to deal with the BE returning multiple timings for a
// single agent script when it should return only one. Reference:
// https://github.com/coder/coder/issues/15413#issuecomment-2493663571
const uniqScriptTimings = uniqBy(
sortBy(agentScriptTimings, (t) => new Date(t.started_at).getTime() * -1),
(t) => t.display_name,
)
const timings = [
...provisionerTimings,
...agentScriptTimings,
...uniqScriptTimings,
...agentConnectionTimings,
];
].sort((a, b) => {
return new Date(a.started_at).getTime() - new Date(b.started_at).getTime();
});
const [isOpen, setIsOpen] = useState(defaultIsOpen);
const isLoading = timings.length === 0;

Expand Down
Loading