chore(vpn): upsert agents with their network status #15659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cf43bdd to
594fbc6
Compare
spikecurtis
reviewed
Nov 26, 2024
594fbc6 to
1347916
Compare
johnstcn
reviewed
Nov 28, 2024
vpn/tunnel.go
Outdated
| resp.Msg = &TunnelMessage_PeerUpdate{ | ||
| PeerUpdate: convertWorkspaceUpdate(state), | ||
| PeerUpdate: update, |
There was a problem hiding this comment.
Is it OK to send a nil PeerUpdate in the response?
There was a problem hiding this comment.
Good catch, I don't think we should.
For pushed updates, if there's no active connection (for whatever reason, should be impossible once the tunnel has started), we'll just send a nil last handshake time.
For requested updates, I think we have to send a nil PeerUpdate if we can't call CurentWorkspaceState.
spikecurtis
reviewed
Dec 2, 2024
d150a25 to
a456281
Compare
ethanndickson
commented
Dec 3, 2024
| @@ -175,8 +175,6 @@ linters-settings: | |||
| - name: modifies-value-receiver | |||
| - name: package-comments | |||
| - name: range | |||
| - name: range-val-address | |||
| - name: range-val-in-closure | |||
There was a problem hiding this comment.
| @@ -238,7 +241,6 @@ linters: | |||
| - errname | |||
| - errorlint | |||
| - exhaustruct | |||
| - exportloopref | |||
There was a problem hiding this comment.
Outdated: https://github.com/kyoh86/exportloopref
ethanndickson
commented
Dec 3, 2024
| default: | ||
| t.logger.Warn(t.ctx, "unhandled manager request", slog.F("request", msg)) | ||
| return resp | ||
| } | ||
| if err := req.sendReply(resp); err != nil { |
There was a problem hiding this comment.
The original code also sent resp := &TunnelMessage{} as a reply for the default: branch, so I assume it's still fine.
469ff7a to
07dc614
Compare
e3f8508 to
561f65f
Compare
07dc614 to
359aaeb
Compare
561f65f to
6cd9c76
Compare
359aaeb to
ba48069
Compare
6cd9c76 to
b2fd151
Compare
b2fd151 to
acdd09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14734.