fix: improve HTML comment stripping

coder · sreya · Nov 27, 2024 · Nov 26, 2024 · Nov 26, 2024 · Nov 26, 2024
commit 99ef0f6fb97bada52e0c5aec64868e85592deb9f
diff --git a/offlinedocs/pages/[[...slug]].tsx b/offlinedocs/pages/[[...slug]].tsx
@@ -38,6 +38,8 @@ import { MdMenu } from "react-icons/md";
 import ReactMarkdown from "react-markdown";
 import rehypeRaw from "rehype-raw";
 import remarkGfm from "remark-gfm";
+import DOMPurify from 'dompurify';
+
 
 type FilePath = string;
 type UrlPath = string;
@@ -194,8 +196,9 @@ const getNavigation = (manifest: Manifest): Nav => {
 	return navigation;
 };
 
-const removeHtmlComments = (string: string) => {
-	return string.replace(/<!--[\s\S]*?-->/g, "");
+const removeHtmlComments = (input: string) => {
+		if (!input) return '';
+		return DOMPurify.sanitize(input, { ALLOW_COMMENTS: false });
 };
 
 export const getStaticPaths: GetStaticPaths = () => {

diff --git a/package.json b/package.json
@@ -13,6 +13,7 @@
 		"prettier": "3.3.3"
 	},
 	"dependencies": {
+		"dompurify": "^3.2.1",
 		"url-parse": "^1.5.10"
 	}
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/site/pnpm-lock.yaml b/site/pnpm-lock.yaml