Skip to content

fix: use url-parse for url construction #15670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 27, 2024
Merged

fix: use url-parse for url construction #15670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a612a54
fix: fix incomplete string escaping
sreya Nov 26, 2024
2766657
fix: fix incomplete string escaping in portforward URL
sreya Nov 26, 2024
99ef0f6
fix: improve HTML comment stripping
sreya Nov 26, 2024
233af4b
update var name
sreya Nov 27, 2024
ec8bea2
fmt
sreya Nov 27, 2024
055fa2b
html minifier
sreya Nov 27, 2024
f5542c7
prettier
sreya Nov 27, 2024
3be0552
no html-minifier
sreya Nov 27, 2024
efc0160
prettier
sreya Nov 27, 2024
cbc1cfa
use native url parser
sreya Nov 27, 2024
bebe628
make fmt
sreya Nov 27, 2024
2c9af96
node:url
sreya Nov 27, 2024
37503da
woes
sreya Nov 27, 2024
029a1d2
no import
sreya Nov 27, 2024
bf108da
html sanitize
sreya Nov 27, 2024
16e3b70
prettier
sreya Nov 27, 2024
bebf898
remove config
sreya Nov 27, 2024
045dc7d
pr comments
sreya Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use native url parser
  • Loading branch information
@sreya
sreya committed Nov 27, 2024
commit cbc1cfa3ea3808b1489d9cfe29154d9e5182a030
4 changes: 0 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
"storybook": "pnpm run -C site/ storybook"
},
"devDependencies": {
"@types/url-parse": "^1.4.11",
"prettier": "3.3.3"
},
"dependencies": {
"url-parse": "^1.5.10"
}
}
30 changes: 0 additions & 30 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions site/src/utils/apps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type * as TypesGen from "api/typesGenerated";
import URLParse from "url-parse";
import { URL } from "url";

export const createAppLinkHref = (
protocol: string,
Expand Down Expand Up @@ -30,10 +30,10 @@ export const createAppLinkHref = (
}

if (appsHost && app.subdomain && app.subdomain_name) {
const url = new URLParse("");
url.set("protocol", protocol);
url.set("hostname", appsHost.replace("*", app.subdomain_name));
url.set("pathname", "/");
const url = new URL("");
url.protocol = protocol;
url.hostname = appsHost.replace("*", app.subdomain_name);
url.pathname = "/";

href = url.toString();
}
Expand Down
8 changes: 4 additions & 4 deletions site/src/utils/portForward.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { WorkspaceAgentPortShareProtocol } from "api/typesGenerated";
import URLParse from "url-parse";
import { URL } from "url";

export const portForwardURL = (
host: string,
Expand All @@ -13,9 +13,9 @@ export const portForwardURL = (
const suffix = protocol === "https" ? "s" : "";

const subdomain = `${port}${suffix}--${agentName}--${workspaceName}--${username}`;
const url = new URLParse("");
url.set("protocol", location.protocol);
url.set("hostname", host.replace("*", subdomain));
const url = new URL("");
url.protocol = location.protocol;
url.hostname = host.replace("*", subdomain);

return url.toString();
};
Expand Down
Loading