Skip to content

docs: add new security doc to best practices section #15805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Dec 9, 2024

@EdwardAngert EdwardAngert self-assigned this Dec 9, 2024
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


EdwardAngert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@EdwardAngert EdwardAngert marked this pull request as ready for review December 13, 2024 18:50
@EdwardAngert
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline suggestions, but overall LGTM and I don't need to review again.

EdwardAngert and others added 3 commits December 16, 2024 09:58
Co-authored-by: Spike Curtis <spike@coder.com>
Co-authored-by: Spike Curtis <spike@coder.com>
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure LGTM. My ask: How can we improve the user journey who may visit "admin -> security". How do we want the search UX to look? Let's build this into a cohesive story in our docs

@EdwardAngert
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@EdwardAngert
Copy link
Contributor Author

Structure LGTM. My ask: How can we improve the user journey who may visit "admin -> security". How do we want the search UX to look? Let's build this into a cohesive story in our docs

@bpmct I added a few links in b270e39 and made a few tweaks to admin/security, but I agree that we should revisit that page and reconsider the findability and IA.

@EdwardAngert EdwardAngert enabled auto-merge (squash) December 16, 2024 20:46
@EdwardAngert EdwardAngert merged commit 74f07ec into main Dec 16, 2024
25 of 26 checks passed
@EdwardAngert EdwardAngert deleted the bp-security branch December 16, 2024 20:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants