-
Notifications
You must be signed in to change notification settings - Fork 924
docs: add new security doc to best practices section #15805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have read the CLA Document and I hereby sign the CLA EdwardAngert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some inline suggestions, but overall LGTM and I don't need to review again.
Co-authored-by: Spike Curtis <spike@coder.com>
Co-authored-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure LGTM. My ask: How can we improve the user journey who may visit "admin -> security". How do we want the search UX to look? Let's build this into a cohesive story in our docs
I have read the CLA Document and I hereby sign the CLA |
@bpmct I added a few links in b270e39 and made a few tweaks to admin/security, but I agree that we should revisit that page and reconsider the findability and IA. |
preview