Skip to content

chore: allow signing in as non-admin users in e2e tests #15892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 19, 2024
Merged

chore: allow signing in as non-admin users in e2e tests #15892

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0dbd385
idk
aslilac Dec 17, 2024
ce83286
yaaaaaaaaaay
aslilac Dec 18, 2024
621af37
🧹
aslilac Dec 18, 2024
924e7dc
yay
aslilac Dec 18, 2024
a4d778e
yaaay
aslilac Dec 19, 2024
d69b623
🙃
aslilac Dec 19, 2024
bc1108e
better comments
aslilac Dec 19, 2024
de7c1db
real good audit logs tests
aslilac Dec 19, 2024
e7dd67b
split up tests
aslilac Dec 19, 2024
2c008e0
🧹
aslilac Dec 19, 2024
c4173ea
🧹
aslilac Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better comments
  • Loading branch information
@aslilac
aslilac committed Dec 19, 2024
commit bc1108e0058cfedb2b0ac522c53e6e48e9c6916b
6 changes: 3 additions & 3 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,21 @@ type LoginOptions = {

export async function login(page: Page, options: LoginOptions = users.admin) {
const ctx = page.context();
// biome-ignore lint/suspicious/noExplicitAny: shenanigans to make life easier
// biome-ignore lint/suspicious/noExplicitAny: reset the current user
(ctx as any)[Symbol.for("currentUser")] = undefined;
await ctx.clearCookies();
await page.goto("/login");
await page.getByLabel("Email").fill(options.email);
await page.getByLabel("Password").fill(options.password);
await page.getByRole("button", { name: "Sign In" }).click();
await expectUrl(page).toHavePathName("/workspaces");
// biome-ignore lint/suspicious/noExplicitAny: shenanigans to make life easier
// biome-ignore lint/suspicious/noExplicitAny: update once logged in
(ctx as any)[Symbol.for("currentUser")] = options;
}

export function currentUser(page: Page): LoginOptions {
const ctx = page.context();
// biome-ignore lint/suspicious/noExplicitAny: shenanigans to make life easier
// biome-ignore lint/suspicious/noExplicitAny: get the current user
const user = (ctx as any)[Symbol.for("currentUser")];

if (!user) {
Expand Down
Loading