Skip to content

chore: apply design changes to the admin settings menu dropdown #15947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2024
Merged

chore: apply design changes to the admin settings menu dropdown #15947

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67b8927
chore: design changes for admin settings menu dropdown
jaaydenh Dec 20, 2024
4606d3a
fix: tests
jaaydenh Dec 20, 2024
fa0aec1
fix: update deployment text
jaaydenh Dec 20, 2024
c009fc7
fix: remove test for users navlink
jaaydenh Dec 20, 2024
dcd3e79
fix: test
jaaydenh Dec 20, 2024
a3b59d3
fix: update selectors
jaaydenh Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove test for users navlink
  • Loading branch information
@jaaydenh
jaaydenh committed Dec 20, 2024
commit c009fc786f15f54b0adad09d1ac981df6cc1debb
19 changes: 0 additions & 19 deletions site/src/modules/dashboard/Navbar/NavbarView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,25 +56,6 @@ describe("NavbarView", () => {
expect((templatesLink as HTMLAnchorElement).href).toContain("/templates");
});

it("users nav link has the correct href", async () => {
renderWithAuth(
<NavbarView
proxyContextValue={proxyContextValue}
user={MockUser}
onSignOut={noop}
canViewDeployment
canViewOrganizations
canViewAllUsers
canViewHealth
canViewAuditLog
/>,
);
const deploymentMenu = await screen.findByText("Admin settings");
await userEvent.click(deploymentMenu);
const userLink = await screen.findByText(navLanguage.users);
expect((userLink as HTMLAnchorElement).href).toContain("/users");
});

it("audit nav link has the correct href", async () => {
renderWithAuth(
<NavbarView
Expand Down
Loading