Skip to content

docs: update external auth to better explain process #16027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Jan 3, 2025

preview

Reference #15968 

Adds more information on how to add external auth, including
docker-compose and docker CLI examples and terraform code for template
integration.

---------

Co-authored-by: Muhammad Atif Ali <me@matifali.dev>
@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Jan 3, 2025
@EdwardAngert EdwardAngert self-assigned this Jan 3, 2025
@EdwardAngert
Copy link
Contributor Author

tried adding tabs for Git providers, but because it's a long list, the overflow is behind some horizontal scroll + it looks like linking to a tab doesn't work yet, so I'm reverting that commit

2025-01-06_14-26-12

@EdwardAngert EdwardAngert marked this pull request as ready for review January 6, 2025 21:29
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but the restructure looks good to me.

@phorcys420
Copy link
Member

tried adding tabs for Git providers, but because it's a long list, the overflow is behind some horizontal scroll + it looks like linking to a tab doesn't work yet, so I'm reverting that commit

It'd be nice if our docs supported dropdown menus for this type of use-case.

Copy link
Member

@phorcys420 phorcys420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for what Atif pointed out, looks good to me overall.

@EdwardAngert EdwardAngert merged commit ee1829b into main Jan 7, 2025
27 checks passed
@EdwardAngert EdwardAngert deleted the 15970-external-auth-update branch January 7, 2025 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants