Skip to content

feat(helm): add support for nodePort specification in LoadBalancer services helm chart #16032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 20, 2025
Merged

feat(helm): add support for nodePort specification in LoadBalancer services helm chart #16032

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efb0468
feat(helm\coder\templates\service.yaml): support nodePort specificati…
MRColorR Jan 3, 2025
cd88420
chore(helm\coder\values.yaml): updated inline comments to reflect the…
MRColorR Jan 3, 2025
2393104
Merge branch 'coder:main' into feat/loadbalancer-nodeport
MRColorR Jan 16, 2025
4c2b7a4
chore(helm): adjust nodeport whitespace in service.yaml template for …
MRColorR Jan 16, 2025
25f85d0
feat(tests): added LoadBalancer nodePort type test cases and updated …
MRColorR Jan 16, 2025
46d6707
Merge branch 'coder:main' into feat/loadbalancer-nodeport
MRColorR Jan 16, 2025
6ab963a
Merge branch 'coder:main' into feat/loadbalancer-nodeport
MRColorR Jan 16, 2025
e7baf75
chore(tests): added nodePort type test and updated LoadBalancer type …
MRColorR Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(helm\coder\templates\service.yaml): support nodePort specificati… 
…on for LoadBalancer services, expanding #8993 work
  • Loading branch information
@MRColorR
MRColorR committed Jan 3, 2025
commit efb0468237b4465ac3c726771b4d08f227b84fed
4 changes: 2 additions & 2 deletions helm/coder/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ spec:
port: 80
targetPort: "http"
protocol: TCP
{{ if eq .Values.coder.service.type "NodePort" }}
{{ if or (eq .Values.coder.service.type "NodePort") (eq .Values.coder.service.type "LoadBalancer") }}
nodePort: {{ .Values.coder.service.httpNodePort }}
{{ end }}
{{- if eq (include "coder.tlsEnabled" .) "true" }}
- name: "https"
port: 443
targetPort: "https"
protocol: TCP
{{ if eq .Values.coder.service.type "NodePort" }}
{{ if or (eq .Values.coder.service.type "NodePort") (eq .Values.coder.service.type "LoadBalancer") }}
nodePort: {{ .Values.coder.service.httpsNodePort }}
{{ end }}
{{- end }}
Expand Down