Skip to content

chore(cli): skip scaletest tests when race detector enabled #16033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

chore(cli): skip scaletest tests when race detector enabled #16033

merged 1 commit into from
Jan 3, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jan 3, 2025 •
edited
Loading

Fixes coder/internal#265

This isn't an ideal solution but the race detector tends to make these flake out.

@johnstcn johnstcn requested a review from mafredri January 3, 2025 18:56
@johnstcn johnstcn self-assigned this Jan 3, 2025
@johnstcn johnstcn enabled auto-merge (squash) January 3, 2025 19:15
mafredri
mafredri approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is due to a regression or some behavior changing. Haven’t seen this before. OK with disabling these for now though 👍

@johnstcn johnstcn merged commit 616d37d into main Jan 3, 2025
34 checks passed
@johnstcn johnstcn deleted the cj/flake/scaletest-workspace-traffic-race branch January 3, 2025 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake: TestScaleTestWorkspaceTraffic: copy did not close in time`
2 participants
@johnstcn @mafredri