Skip to content

chore: bump gopkg.in/DataDog/dd-trace-go.v1 from 1.69.0 to 1.70.3 #16066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 8, 2025

Bumps gopkg.in/DataDog/dd-trace-go.v1 from 1.69.0 to 1.70.3.

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
gopkg.in/DataDog/dd-trace-go.v1 [>= 1.58.a, < 1.59]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot force-pushed the dependabot/go_modules/gopkg.in/DataDog/dd-trace-go.v1-1.70.3 branch from 6d2e88b to 2338ce9 Compare January 8, 2025 13:08
@deansheather deansheather requested review from johnstcn and removed request for deansheather January 8, 2025 13:27
@johnstcn johnstcn self-assigned this Jan 8, 2025
@johnstcn
Copy link
Member

johnstcn commented Jan 8, 2025

Sadly this introduces a goroutine leak:

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 10 in state sync.Cond.Wait, with sync.runtime_notifyListWait on top of the stack:
sync.runtime_notifyListWait(0xc000097c10, 0x0)
	/opt/hostedtoolcache/go/1.22.8/x64/src/runtime/sema.go:569 +0x159
sync.(*Cond).Wait(0x0?)
	/opt/hostedtoolcache/go/1.22.8/x64/src/sync/cond.go:70 +0x85
github.com/cihub/seelog.(*asyncLoopLogger).processItem(0xc000197830)
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e57575/behavior_asynclooplogger.go:[50](https://github.com/coder/coder/actions/runs/12671226456/job/35312524127?pr=16066#step:12:51) +0x99
github.com/cihub/seelog.(*asyncLoopLogger).processQueue(0xc000197830)
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134[53](https://github.com/coder/coder/actions/runs/12671226456/job/35312524127?pr=16066#step:12:54)2-f561c5e57575/behavior_asynclooplogger.go:63 +0x33
created by github.com/cihub/seelog.NewAsyncLoopLogger in goroutine 1
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e57575/behavior_asynclooplogger.go:40 +0xcf
 Goroutine 11 in state sync.Cond.Wait, with sync.runtime_notifyListWait on top of the stack:
sync.runtime_notifyListWait(0xc000097d90, 0x0)
	/opt/hostedtoolcache/go/1.22.8/x64/src/runtime/sema.go:[56](https://github.com/coder/coder/actions/runs/12671226456/job/35312524127?pr=16066#step:12:57)9 +0x159
sync.(*Cond).Wait(0x0?)
	/opt/hostedtoolcache/go/1.22.8/x64/src/sync/cond.go:70 +0x85
github.com/cihub/seelog.(*asyncLoopLogger).processItem(0xc000197950)
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e[57](https://github.com/coder/coder/actions/runs/12671226456/job/35312524127?pr=16066#step:12:58)575/behavior_asynclooplogger.go:50 +0x99
github.com/cihub/seelog.(*asyncLoopLogger).processQueue(0xc000197950)
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e57575/behavior_asynclooplogger.go:63 +0x33
created by github.com/cihub/seelog.NewAsyncLoopLogger in goroutine 1
	/home/runner/go/pkg/mod/github.com/cihub/seelog@v0.0.0-20170130134532-f561c5e57575/behavior_asynclooplogger.go:40 +0xcf
]
FAIL	github.com/coder/coder/v2/cli	1.082s
FAIL
make: *** [Makefile:757: cli/testdata/.gen-golden] Error 1

It's being tracked in DataDog/dd-trace-go#2987

johnstcn added a commit that referenced this pull request Jan 8, 2025
- Adds `testutil.GoleakOptions` and consolidates existing options to
this location
- Pre-emptively adds required ignore for this Dependabot PR to pass CI
#16066
@johnstcn
Copy link
Member

johnstcn commented Jan 8, 2025

@dependabot rebase

Bumps gopkg.in/DataDog/dd-trace-go.v1 from 1.69.0 to 1.70.3.

---
updated-dependencies:
- dependency-name: gopkg.in/DataDog/dd-trace-go.v1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/gopkg.in/DataDog/dd-trace-go.v1-1.70.3 branch from 2338ce9 to fa2f129 Compare January 8, 2025 15:51
@johnstcn johnstcn merged commit 9494afa into main Jan 8, 2025
30 checks passed
@johnstcn johnstcn deleted the dependabot/go_modules/gopkg.in/DataDog/dd-trace-go.v1-1.70.3 branch January 8, 2025 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant