feat: add --ssh-host-prefix flag for "coder ssh" #16088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure looks unrelated. Flaky test? |
|
Looks like it, although I'm having trouble getting it to Flake to confirm :/ |
|
Re-running the tests passed, it's a flake ❄️ I'll come back to this in the morning and try to fix it 😎 |
|
Ah hey the flake was caught and fixed yesterday, just in the process of being merged: coder/internal#269 |
bcpeinhardt
approved these changes
Jan 10, 2025
aaronlehmann
added a commit
to aaronlehmann/jetbrains-coder
that referenced
this pull request
Jan 10, 2025
This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment). Depends on coder/coder#16088
mafredri
approved these changes
Jan 10, 2025
bcpeinhardt
reviewed
Jan 13, 2025
This adds a flag matching `--ssh-host-prefix` from `coder config-ssh` to `coder ssh`. By trimming a custom prefix from the argument, we can set up wildcard-based `Host` entries in SSH config for the IDE plugins (and eventually `coder config-ssh`). We also replace `--` in the argument with `/`, so ownership can be specified in wildcard-based SSH hosts like `<owner>--<workspace>`.
e32e656 to
0499bda
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag matching
--ssh-host-prefixfromcoder config-sshtocoder ssh. By trimming a custom prefix from the argument, we can set up wildcard-basedHostentries in SSH config for the IDE plugins (and eventuallycoder config-ssh).We also replace
--in the argument with/, so ownership can be specified in wildcard-based SSH hosts like<owner>--<workspace>.Replaces #16087.
Part of #14986.
Related to #16078 and #16080.