Skip to content

chore: only notify about CI failure on main if required job fails #16114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: only notify about CI failure on main if required job fails #16114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e53b675
Only notify if required job fails
dannykopping Jan 13, 2025
d48290f
Remove failing job name
dannykopping Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,8 +1252,10 @@ jobs:
make sqlc-vet

notify-slack-on-failure:
needs:
- required
runs-on: ubuntu-latest
if: always() && failure() && github.ref == 'refs/heads/main'
if: failure() && github.ref == 'refs/heads/main'

steps:
- name: Send Slack notification
Expand All @@ -1276,10 +1278,6 @@ jobs:
"type": "mrkdwn",
"text": "*Workflow:*\n${{ github.workflow }}"
},
{
"type": "mrkdwn",
"text": "*Failed Job:*\n${{ github.job }}"
},
{
"type": "mrkdwn",
"text": "*Committer:*\n${{ github.actor }}"
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/nightly-gauntlet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ jobs:
"type": "mrkdwn",
"text": "*Workflow:*\n${{ github.workflow }}"
},
{
"type": "mrkdwn",
"text": "*Failed Job:*\n${{ github.job }}"
},
{
"type": "mrkdwn",
"text": "*Committer:*\n${{ github.actor }}"
Expand Down
Loading