feat: improve metrics and UI for user engagement on the platform #16134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ PR 16134 Updated successfully.
|
|
I do not see the chart for License utilization as per this design. Has that been removed from Scope? Or Is that coming in a separate PR? |
jaaydenh
reviewed
Jan 16, 2025
site/tailwind.config.js
Outdated
| @@ -16,6 +16,7 @@ module.exports = { | |||
| fontSize: { | |||
| "2xs": ["0.625rem", "0.875rem"], | |||
| sm: ["0.875rem", "1.5rem"], | |||
| md: ["1rem", "1.5rem"], | |||
There was a problem hiding this comment.
text-base covers the size ["1rem", "1.5rem"] so there shouldn't be a need to explicitly set md, see https://tailwindcss.com/docs/font-size#setting-the-line-height
SasSwart
requested changes
Jan 16, 2025
site/src/pages/DeploymentSettingsPage/GeneralSettingsPage/GeneralSettingsPage.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/GeneralSettingsPage/GeneralSettingsPageView.tsx
Show resolved
Hide resolved
|
The PR has been updated but is still waiting on a few definitions:
Despite these pending decisions, it’s ready for review. |
jaaydenh
reviewed
Jan 16, 2025
| className="size-3 inline-flex items-center justify-center" | ||
| aria-label="Legend for license seat limit in the chart" | ||
| > | ||
| <div className="w-full border-b-1 border-t-1 border-dashed border-content-disabled" /> |
There was a problem hiding this comment.
Suggested change
| <div className="w-full border-b-1 border-t-1 border-dashed border-content-disabled" /> | |
| <div className="w-full border-b border-t border-dashed border-content-disabled" /> |
this reduces the width to better match the design
jaaydenh
approved these changes
Jan 16, 2025
|
Great work @BrunoQuaresma. A few small notes for consideration, but we can get to them as follow-up:
|
SasSwart
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can explore the new chart on Storybook.
Preview:
Close #15297