Skip to content

feat: improve metrics and UI for user engagement on the platform #16134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust engagement chart
  • Loading branch information
BrunoQuaresma committed Jan 16, 2025
commit 4b7bf9f198029ef4bbceef5bb6b58bf40518d13c
4 changes: 2 additions & 2 deletions site/src/components/Link/Link.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Slot } from "@radix-ui/react-slot";
import { Slot, Slottable } from "@radix-ui/react-slot";
import { type VariantProps, cva } from "class-variance-authority";
import { SquareArrowOutUpRightIcon } from "lucide-react";
import { forwardRef } from "react";
Expand Down Expand Up @@ -38,7 +38,7 @@ export const Link = forwardRef<HTMLAnchorElement, LinkProps>(
ref={ref}
{...props}
>
{children}
<Slottable>{children}</Slottable>
<SquareArrowOutUpRightIcon aria-hidden="true" />
</Comp>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,7 @@ const meta: Meta<typeof GeneralSettingsPageView> = {
hidden: false,
},
],
activeUsersCount: [
{ date: "1/1/2024", count: 150 },
{ date: "1/2/2024", count: 165 },
{ date: "1/3/2024", count: 180 },
{ date: "1/4/2024", count: 155 },
{ date: "1/5/2024", count: 190 },
{ date: "1/6/2024", count: 200 },
{ date: "1/7/2024", count: 210 },
],
dailyActiveUsers: MockDeploymentDAUResponse,
invalidExperiments: [],
safeExperiments: [],
entitlements: undefined,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ import {
CollapsibleContent,
CollapsibleTrigger,
} from "components/Collapsible/Collapsible";
import { Link } from "components/Link/Link";
import { Spinner } from "components/Spinner/Spinner";
import { ChevronRightIcon, ExternalLinkIcon } from "lucide-react";
import { ChevronRightIcon } from "lucide-react";
import type { FC } from "react";
import { Link } from "react-router-dom";
import { Area, AreaChart, CartesianGrid, XAxis, YAxis } from "recharts";
import { Link as RouterLink } from "react-router-dom";

const chartConfig = {
users: {
Expand Down Expand Up @@ -64,8 +65,17 @@ export const UserEngagementChart: FC<UserEngagementChartProps> = ({ data }) => {
A user is considered "engaged" if they initiate a connection to
their workspace via apps, web terminal, or SSH. The graph displays
the daily count of unique users who engaged at least once, with
additional insights available through the Activity Audit and
License Consumption tools.
additional insights available through the{" "}
<Link size="sm" asChild>
<RouterLink to="/audit">Activity Audit</RouterLink>
</Link>{" "}
and{" "}
<Link size="sm" asChild>
<RouterLink to="/deployment/licenses">
License Consumption
</RouterLink>
</Link>{" "}
tools.
</p>
</CollapsibleContent>
</Collapsible>
Expand All @@ -83,6 +93,7 @@ export const UserEngagementChart: FC<UserEngagementChartProps> = ({ data }) => {
accessibilityLayer
data={data}
margin={{
top: 10,
left: 0,
right: 0,
}}
Expand Down