Skip to content

chore(provisionerd): use correct log levels for template provisioner logs #16232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

DanielleMaywood
Copy link
Contributor

Relates to #14062

Previously a logProvisionerJobLog helper was added in #6508 to forward logs from the provisioner at the correct log level, but this was only used for logs produced in buildWorkspace.

This PR uses this helper for forwarding logs produced in runTemplateImportParse and runTemplateImportProvisionWithRichParameters at the correct log level.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review January 23, 2025 09:22
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Nice catch @DanielleMaywood !

@DanielleMaywood DanielleMaywood merged commit a6e054a into main Jan 23, 2025
35 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-log-on-template-import branch January 23, 2025 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants