Skip to content

chore: remove patch condition for dependabot PRs #16279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 27, 2025

Many of the depdnabot PRs are minor updates, so removing this condition to make automation more useful.

We only merge if all tests pass, so this should be safe.

Most of the depdnabot PRs are minor updates so removing this condition to make automation more usdeul
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, especially considering if a minor update does change something despite all tests passing, it's unlikely a manual review would've caught it anyway. See #16140 caused by #16066 for a case study.

@matifali matifali enabled auto-merge (squash) January 27, 2025 11:51
@matifali matifali merged commit 7d6b735 into main Jan 27, 2025
33 checks passed
@matifali matifali deleted the atif/merge-all-dependabot-PRs branch January 27, 2025 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants