Skip to content

chore: Add .editorconfig, subshell dir changes in scripts #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2022
Merged

chore: Add .editorconfig, subshell dir changes in scripts #1649

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6537509
fix: Ensure ~/go/bin dir exists during make install
mafredri May 23, 2022
7506892
chore: Add .editorconfig to project root
mafredri May 23, 2022
afbaeb8
chore: Perform dir changes in subshell and run shfmt
mafredri May 23, 2022
4d64125
chore: Add .editorconfig for site/
mafredri May 23, 2022
d8da3ff
Set indent for tf and sql files too
mafredri May 23, 2022
2c491bd
Fix dump.sql formatting exception
mafredri May 23, 2022
76760a6
Revert git rev-parse removal
mafredri May 23, 2022
0a91dd6
Add make targets: fmt/shfmt and lint/shellcheck
mafredri May 23, 2022
ceedec8
Run shfmt and shellcheck in CI
mafredri May 23, 2022
945ddc9
Add $GOPATH/bin to path in CI for shfmt
mafredri May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add .editorconfig to project root
  • Loading branch information
@mafredri
mafredri committed May 23, 2022
commit 75068929acf18045fc482d68a792ebadd2bfc5cf
12 changes: 12 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
root = true

[*]
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = tab

[*.{md,json,yaml}]
indent_style = space
indent_size = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark: I think we may need to iterate on this a bit:

Copy link
Member Author

@mafredri mafredri May 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a .editorconfig to the site/ package that defaults to spaces, should make prettier happy and I think that's the most common indentation for site/, so we can add exceptions after they're discovered.

Re: Go, which changes do you think we should make? Except for default space, I think our settings read fairly similar. I'm OK with copying those straight off if that's the preference but I matched style of e.g. .md for what's previously used in this project.

One change I would make though is to not define indent_size for indent_style = tab because that's just evil and taking peoples preference of visual tab size away from them. 😄