Skip to content

chore: Add .editorconfig, subshell dir changes in scripts #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 27, 2022
Merged

chore: Add .editorconfig, subshell dir changes in scripts #1649

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6537509
fix: Ensure ~/go/bin dir exists during make install
mafredri May 23, 2022
7506892
chore: Add .editorconfig to project root
mafredri May 23, 2022
afbaeb8
chore: Perform dir changes in subshell and run shfmt
mafredri May 23, 2022
4d64125
chore: Add .editorconfig for site/
mafredri May 23, 2022
d8da3ff
Set indent for tf and sql files too
mafredri May 23, 2022
2c491bd
Fix dump.sql formatting exception
mafredri May 23, 2022
76760a6
Revert git rev-parse removal
mafredri May 23, 2022
0a91dd6
Add make targets: fmt/shfmt and lint/shellcheck
mafredri May 23, 2022
ceedec8
Run shfmt and shellcheck in CI
mafredri May 23, 2022
945ddc9
Add $GOPATH/bin to path in CI for shfmt
mafredri May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run shfmt and shellcheck in CI
  • Loading branch information
@mafredri
mafredri committed May 23, 2022
commit ceedec8eecc32e9d564e108738980a533b057b38
14 changes: 14 additions & 0 deletions .github/workflows/coder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,17 @@ jobs:
with:
version: v1.46.0

style-lint-shellcheck:
name: style/lint/shellcheck
timeout-minutes: 5
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Run ShellCheck
uses: ludeeus/action-shellcheck@1.1.0
with:
ignore: node_modules

style-lint-typescript:
name: "style/lint/typescript"
timeout-minutes: 5
Expand Down Expand Up @@ -133,6 +144,9 @@ jobs:
- name: Install node_modules
run: ./scripts/yarn_install.sh

- name: Install shfmt
run: go install mvdan.cc/sh/v3/cmd/shfmt@v3.5.0

- run: "make --output-sync -j -B fmt"

test-go:
Expand Down