feat(site): add support for presets to the create workspace page #16567
Conversation
| value: preset.ID, | ||
| })), | ||
| ]; | ||
| }, [presets]); |
There was a problem hiding this comment.
We only use useMemo when really necessary. In this case, it would be ok to compute this on every render.
There was a problem hiding this comment.
Cool. I will remove the useMemo. For my own learning: Can you help me understand why not to use useMemo in this case?
There was a problem hiding this comment.
It’s just a matter of adding complexity—caching—in a place where it’s not really needed.
| presets, | ||
| parameters, | ||
| form.setFieldValue, | ||
| ]); |
There was a problem hiding this comment.
I'm assuming this effect is to set in the form the default values right? If yes, I think the best place to set them is in the form initialValues prop here
.There was a problem hiding this comment.
This effect is not only for default values, but also for if the user chooses a new preset. If they choose a new preset then this effect will autofill the form for them using the new preset values.
| @@ -189,6 +245,31 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({ | |||
| </Alert> | |||
| )} | |||
|
|
|||
| {presets.length > 0 && ( | |||
| <FormSection | |||
There was a problem hiding this comment.
A form section should be used to group similar fields. I'm usually don't like to have sections with a single field 🤔 but I will leave this up to you. I was wondering if this could not be in the General section.
There was a problem hiding this comment.
Understood. There is another issue open to consider the UX and design of this entire page. I have made this change as requested, but I would like to request that we defer further design discussions for the mockups.
|
Removed myself as a reviewer; this is not my area of expertise. All I'd be able to contribute is vibes or a stamp, neither of which are valuable. |
This pull request adds support for presets to the create workspace page. This behaviour can be seen in the storybook. This will not be visible in dogfood until we merge support for presets in the provisioners.
There is more frontend work to be done before this is ready for a general release, but this should be sufficient for dogfood testing