Skip to content

fix: include origin in support link #16572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 14, 2025
Merged

fix: include origin in support link #16572

merged 9 commits into from
Feb 14, 2025

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 14, 2025

Fixes: #15542

This PR ensures that a support link has window.origin prepended (if missing)

@mtojek mtojek self-assigned this Feb 14, 2025
@mtojek mtojek requested review from matifali and johnstcn February 14, 2025 11:47
@mtojek mtojek marked this pull request as ready for review February 14, 2025 11:47
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Marcin ❤️ you are literally killing bugs. 🐛

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have some unit tests for includeOrigin, but LGTM otherwise 👍

@mtojek
Copy link
Member Author

mtojek commented Feb 14, 2025

I'd like to have some unit tests for includeOrigin

That's why I added the storybook case, but let me see if I can squeeze a simple unit test 👍

@mtojek mtojek enabled auto-merge (squash) February 14, 2025 12:17
@mtojek mtojek merged commit 1c5a042 into main Feb 14, 2025
29 of 30 checks passed
@mtojek mtojek deleted the 15542-lins branch February 14, 2025 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix Coder support links relative path
3 participants