-
Notifications
You must be signed in to change notification settings - Fork 875
fix: include origin in support link #16572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Marcin ❤️ you are literally killing bugs. 🐛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have some unit tests for includeOrigin
, but LGTM otherwise 👍
That's why I added the storybook case, but let me see if I can squeeze a simple unit test 👍 |
Fixes: #15542
This PR ensures that a support link has
window.origin
prepended (if missing)