Skip to content

fix: force lowercase DNS hostnames for VPN #16613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: force lowercase DNS hostnames for VPN #16613

merged 1 commit into from
Feb 20, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Feb 19, 2025 •
edited
Loading

Closes coder/coder-desktop-macos#54

I've also double checked that agents with hyphens & underscores play nice once programmed, as do workspaces with hyphens:

$ ping6 main_agent-1.main-workspace.admin.coder
PING6(56=40+8+8 bytes) fd60:627a:a42b:4e91:88c0:da4a:df4f:b54e --> fd60:627a:a42b:46d4:8b55:e549:e498:e6f5

also fine in Firefox & Safari, though I'm a little surprised underscores work.

@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Feb 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson changed the title fix(vpn): force lowercase DNS hostnames fix: force lowercase DNS hostnames for VPN Feb 19, 2025
@ethanndickson ethanndickson marked this pull request as ready for review February 19, 2025 02:44
@ethanndickson ethanndickson force-pushed the ethan/vpn-lowercase-dns branch from 1593e9e to e54184f Compare February 19, 2025 05:26
@ethanndickson ethanndickson changed the base branch from main to ethan/case-insensitive-unique-agent-names February 19, 2025 05:27
@ethanndickson ethanndickson mentioned this pull request Feb 19, 2025
Merged
@ethanndickson ethanndickson force-pushed the ethan/case-insensitive-unique-agent-names branch from ea0c978 to 5241805 Compare February 19, 2025 05:30
@ethanndickson ethanndickson force-pushed the ethan/vpn-lowercase-dns branch from e54184f to 278750e Compare February 19, 2025 05:30
@ethanndickson ethanndickson force-pushed the ethan/case-insensitive-unique-agent-names branch from 5241805 to 566e3de Compare February 19, 2025 05:50
@ethanndickson ethanndickson force-pushed the ethan/vpn-lowercase-dns branch from 278750e to 678c358 Compare February 19, 2025 05:50
@ethanndickson Graphite App
Copy link
Member Author

ethanndickson commented Feb 20, 2025 •
edited
Loading

Merge activity

  • Feb 19, 8:51 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 8:53 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 19, 9:02 PM EST: A user merged this pull request with Graphite.

@ethanndickson ethanndickson changed the base branch from ethan/case-insensitive-unique-agent-names to graphite-base/16613 February 20, 2025 01:51
@ethanndickson ethanndickson changed the base branch from graphite-base/16613 to main February 20, 2025 01:51
@ethanndickson ethanndickson force-pushed the ethan/vpn-lowercase-dns branch from 678c358 to c91522c Compare February 20, 2025 01:52
@ethanndickson ethanndickson merged commit 92870f0 into main Feb 20, 2025
31 checks passed
@ethanndickson ethanndickson deleted the ethan/vpn-lowercase-dns branch February 20, 2025 02:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThomasK33 ThomasK33 ThomasK33 approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS doesn't work for workspaces with uppercase letters in their names
3 participants
@ethanndickson @ThomasK33 @deansheather