Skip to content

chore: perform several small frontend permissions refactors #16735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025
Merged

chore: perform several small frontend permissions refactors #16735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee5013f
can't disappoint the fans :)
aslilac Mar 7, 2025
2413f96
🙄
aslilac Mar 7, 2025
18eb42e
:|
aslilac Mar 7, 2025
58e1653
:^|
aslilac Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
:^|
  • Loading branch information
@aslilac
aslilac committed Mar 7, 2025
commit 58e1653ea3e2084a1f7624bf131691078c5a6a5f
10 changes: 5 additions & 5 deletions site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import type { FC } from "react";
import { Helmet } from "react-helmet-async";
import { useQuery } from "react-query";
import { pageTitle } from "utils/page";
import { GeneralSettingsPageView } from "./GeneralSettingsPageView";
import { OverviewPageView } from "./OverviewPageView";

const GeneralSettingsPage: FC = () => {
const OverviewPage: FC = () => {
const { deploymentConfig } = useDeploymentConfig();
const safeExperimentsQuery = useQuery(availableExperiments());

Expand All @@ -26,9 +26,9 @@ const GeneralSettingsPage: FC = () => {
return (
<>
<Helmet>
<title>{pageTitle("General Settings")}</title>
<title>{pageTitle("Overview", "Deployment")}</title>
</Helmet>
<GeneralSettingsPageView
<OverviewPageView
deploymentOptions={deploymentConfig.options}
dailyActiveUsers={dailyActiveUsers}
invalidExperiments={invalidExperiments}
Expand All @@ -38,4 +38,4 @@ const GeneralSettingsPage: FC = () => {
);
};

export default GeneralSettingsPage;
export default OverviewPage;
10 changes: 5 additions & 5 deletions site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import type { Meta, StoryObj } from "@storybook/react";
import { MockDeploymentDAUResponse } from "testHelpers/entities";
import { GeneralSettingsPageView } from "./GeneralSettingsPageView";
import { OverviewPageView } from "./OverviewPageView";

const meta: Meta<typeof GeneralSettingsPageView> = {
title: "pages/DeploymentSettingsPage/GeneralSettingsPageView",
component: GeneralSettingsPageView,
const meta: Meta<typeof OverviewPageView> = {
title: "pages/DeploymentSettingsPage/OverviewPageView",
component: OverviewPageView,
args: {
deploymentOptions: [
{
Expand Down Expand Up @@ -42,7 +42,7 @@ const meta: Meta<typeof GeneralSettingsPageView> = {
};

export default meta;
type Story = StoryObj<typeof GeneralSettingsPageView>;
type Story = StoryObj<typeof OverviewPageView>;

export const Page: Story = {};

Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/DeploymentSettingsPage/OverviewPage/OverviewPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ import { Alert } from "../../../components/Alert/Alert";
import OptionsTable from "../OptionsTable";
import { UserEngagementChart } from "./UserEngagementChart";

export type GeneralSettingsPageViewProps = {
export type OverviewPageViewProps = {
deploymentOptions: SerpentOption[];
dailyActiveUsers: DAUsResponse | undefined;
readonly invalidExperiments: Experiments | string[];
readonly safeExperiments: Experiments | string[];
};

export const GeneralSettingsPageView: FC<GeneralSettingsPageViewProps> = ({
export const OverviewPageView: FC<OverviewPageViewProps> = ({
deploymentOptions,
dailyActiveUsers,
safeExperiments,
Expand Down
Loading