Skip to content

Fix: fix Workspace storybook and remove unnecessary fetching from xService #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022

Conversation

presleyp
Copy link
Contributor

Fixes #1675

@presleyp presleyp requested a review from a team as a code owner May 23, 2022 19:47
@presleyp presleyp self-assigned this May 23, 2022
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for fixing these!!!

@presleyp presleyp merged commit 9b70a9b into main May 24, 2022
@presleyp presleyp deleted the workspace-story/presleyp/1675 branch May 24, 2022 00:04
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
…rvice (#1682)

* Make workspace machine ephemeral to limit polling

* Fix Workspace storybook

* Lint

* Remove breadcrumb from workspaceXService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Workspace story
3 participants