chore: migrate settings page tables from mui to shadcn #16896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
code all looks great!
from the screenshots tho, it's weird that the custom role rows are taller than the built-in rows. the custom roles are just a bit taller, and the extra spacing looks better imo. it seems like this is actually an existing issue that the overall smaller sizes just make more pronounced now, but could we even out the sizes?
everything else seems very straight forward and good, that's my one request 😄
Comment on lines
+369
to
+371
| <TableHead className="w-2/5">IdP organization</TableHead> | ||
| <TableHead className="w-3/5">Coder organization</TableHead> | ||
| <TableHead className="w-auto" /> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Roles
Group Page
Groups Page
Users Page
