Skip to content

feat(coderd): remove greetings from notifications templates #16991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wokr on golden files
  • Loading branch information
defelmnq committed Mar 18, 2025
commit 9ce82de638e155e1c71810ae00caba7966709769
2 changes: 1 addition & 1 deletion coderd/notifications/dispatch/smtp/html.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
{{ .Labels._subject }}
</h1>
<div style="line-height: 1.5;">
Hi {{ .UserUsername }},
Hi,
{{ .Labels._body }}
</div>
<div style="text-align: center; margin-top: 32px;">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ argin: 8px 0 32px; line-height: 1.5;">
Template "Bobby's Template" deleted
</h1>
<div style=3D"line-height: 1.5;">
Hi,
<p>Hi Bobby,</p>

<p>The template <strong>Bobby&rsquo;s Template</strong> was deleted by <str=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hello Bobby,

The template alpha has been deprecated with the following message:

This template has been replaced by beta
Expand Down Expand Up @@ -53,10 +51,9 @@ argin: 8px 0 32px; line-height: 1.5;">
Template 'alpha' has been deprecated
</h1>
<div style=3D"line-height: 1.5;">
<p>Hello Bobby,</p>

<p>The template <strong>alpha</strong> has been deprecated with the followi=
ng message:</p>
Hi,
<p>The template <strong>alpha</strong> has been deprecated with the=
following message:</p>

<p><strong>This template has been replaced by beta</strong></p>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

This is a test notification.


Expand Down Expand Up @@ -46,9 +44,8 @@ argin: 8px 0 32px; line-height: 1.5;">
A test notification
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>This is a test notification.</p>
Hi,
<p>This is a test notification.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

User account bobby has been activated.

The account belongs to William Tables and it was activated by rob.


View accounts: http://test.com/deployment/users?filter=3Dstatus%3Aactive

Expand Down Expand Up @@ -47,12 +43,8 @@ argin: 8px 0 32px; line-height: 1.5;">
User account "bobby" activated
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>User account <strong>bobby</strong> has been activated.</p>

<p>The account belongs to <strong>William Tables</strong> and it was activa=
ted by <strong>rob</strong>.</p>
Hi,
<p>User account <strong>bobby</strong> has been activated.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

New user account bobby has been created.

This new user account was created for William Tables by rob.


View accounts: http://test.com/deployment/users?filter=3Dstatus%3Aactive

Expand Down Expand Up @@ -47,12 +43,8 @@ argin: 8px 0 32px; line-height: 1.5;">
User account "bobby" created
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>New user account <strong>bobby</strong> has been created.</p>

<p>This new user account was created for <strong>William Tables</strong> by=
<strong>rob</strong>.</p>
Hi,
<p>New user account <strong>bobby</strong> has been created.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

User account bobby has been deleted.

The deleted account belonged to William Tables and was deleted by rob.


View accounts: http://test.com/deployment/users?filter=3Dstatus%3Aactive

Expand Down Expand Up @@ -47,12 +43,8 @@ argin: 8px 0 32px; line-height: 1.5;">
User account "bobby" deleted
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>User account <strong>bobby</strong> has been deleted.</p>

<p>The deleted account belonged to <strong>William Tables</strong> and was =
deleted by <strong>rob</strong>.</p>
Hi,
<p>User account <strong>bobby</strong> has been deleted.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,8 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

User account bobby has been suspended.

The account belongs to William Tables and it was suspended by rob.


View suspended accounts: http://test.com/deployment/users?filter=3Dstatus%3=
Asuspended
Expand Down Expand Up @@ -48,12 +44,8 @@ argin: 8px 0 32px; line-height: 1.5;">
User account "bobby" suspended
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>User account <strong>bobby</strong> has been suspended.</p>

<p>The account belongs to <strong>William Tables</strong> and it was suspen=
ded by <strong>rob</strong>.</p>
Hi,
<p>User account <strong>bobby</strong> has been suspended.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,
A request to reset the password for your Coder account has been made. Your =
one-time passcode is:

Use the link below to reset your password.
fad9020b-6562-4cdb-87f1-0486f1bea415

If you did not make this request, you can ignore this message.
If you did not request to reset your password, you can ignore this message.


Reset password: http://test.com/reset-password/change?otp=3Dfad9020b-6562-4=
Expand Down Expand Up @@ -48,11 +49,14 @@ argin: 8px 0 32px; line-height: 1.5;">
Reset your password for Coder
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>
Hi,
<p>A request to reset the password for your Coder account has been =
made. Your one-time passcode is:</p>

<p>Use the link below to reset your password.</p>
<p><strong>fad9020b-6562-4cdb-87f1-0486f1bea415</strong></p>

<p>If you did not make this request, you can ignore this message.</p>
<p>If you did not request to reset your password, you can ignore this messa=
ge.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,9 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

Your workspace bobby-workspace has been updated automatically to the latest=
template version (1.0).

Reason for update: template now includes catnip.


View workspace: http://test.com/@bobby/bobby-workspace

Expand Down Expand Up @@ -48,12 +44,9 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" updated automatically
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>Your workspace <strong>bobby-workspace</strong> has been updated automat=
ically to the latest template version (1.0).</p>

<p>Reason for update: <strong>template now includes catnip</strong>.</p>
Hi,
<p>Your workspace <strong>bobby-workspace</strong> has been updated=
automatically to the latest template version (1.0).</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

Automatic build of your workspace bobby-workspace failed.

The specified reason was "autostart".


Expand Down Expand Up @@ -47,12 +44,10 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" autobuild failed
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>Automatic build of your workspace <strong>bobby-workspace</strong> faile=
d.</p>

<p>The specified reason was &ldquo;<strong>autostart</strong>&rdquo;.</p>
Hi,
<p>Automatic build of your workspace <strong>bobby-workspace</stron=
g> failed.<br>
The specified reason was &ldquo;<strong>autostart</strong>&rdquo;.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hello Bobby,

The workspace bobby-workspace has been created from the template bobby-temp=
late using version alpha.

Expand Down Expand Up @@ -46,11 +44,10 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace 'bobby-workspace' has been created
</h1>
<div style=3D"line-height: 1.5;">
<p>Hello Bobby,</p>

<p>The workspace <strong>bobby-workspace</strong> has been created from the=
template <strong>bobby-template</strong> using version <strong>alpha</stro=
ng>.</p>
Hi,
<p>The workspace <strong>bobby-workspace</strong> has been created =
from the template <strong>bobby-template</strong> using version <strong>alp=
ha</strong>.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

Your workspace bobby-workspace was deleted.

The specified reason was "autodeleted due to dormancy (autobuild)".


Expand Down Expand Up @@ -49,12 +46,10 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" deleted
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>Your workspace <strong>bobby-workspace</strong> was deleted.</p>

<p>The specified reason was &ldquo;<strong>autodeleted due to dormancy (aut=
obuild)</strong>&rdquo;.</p>
Hi,
<p>Your workspace <strong>bobby-workspace</strong> was deleted.<br>
The specified reason was &ldquo;<strong>autodeleted due to dormancy (autobu=
ild)</strong>&rdquo;.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

Your workspace bobby-workspace was deleted.

The specified reason was "autodeleted due to dormancy (autobuild)".


Expand Down Expand Up @@ -49,12 +46,10 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" deleted
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>Your workspace <strong>bobby-workspace</strong> was deleted.</p>

<p>The specified reason was &ldquo;<strong>autodeleted due to dormancy (aut=
obuild)</strong>&rdquo;.</p>
Hi,
<p>Your workspace <strong>bobby-workspace</strong> was deleted.<br>
The specified reason was &ldquo;<strong>autodeleted due to dormancy (autobu=
ild)</strong>&rdquo;.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" marked as dormant
</h1>
<div style=3D"line-height: 1.5;">
Hi,
<p>Hi Bobby,</p>

<p>Your workspace <strong>bobby-workspace</strong> has been marked as <a hr=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@ MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Bobby,

A manual build of the workspace bobby-workspace using the template bobby-te=
mplate failed (version: bobby-template-version).

The workspace build was initiated by joe.


Expand Down Expand Up @@ -48,13 +45,11 @@ argin: 8px 0 32px; line-height: 1.5;">
Workspace "bobby-workspace" manual build failed
</h1>
<div style=3D"line-height: 1.5;">
<p>Hi Bobby,</p>

<p>A manual build of the workspace <strong>bobby-workspace</strong> using t=
he template <strong>bobby-template</strong> failed (version: <strong>bobby-=
template-version</strong>).</p>

<p>The workspace build was initiated by <strong>joe</strong>.</p>
Hi,
<p>A manual build of the workspace <strong>bobby-workspace</strong>=
using the template <strong>bobby-template</strong> failed (version: <stron=
g>bobby-template-version</strong>).<br>
The workspace build was initiated by <strong>joe</strong>.</p>
</div>
<div style=3D"text-align: center; margin-top: 32px;">
=20
Expand Down
Loading