improve templates for smtp

coder · defelmnq · Mar 21, 2025 · Mar 18, 2025 · Mar 18, 2025 · Mar 18, 2025
commit ddc4e70bd81ce494ec18dbed7b98ff40836aee63
diff --git a/coderd/notifications/dispatch/smtp/html.gotmpl b/coderd/notifications/dispatch/smtp/html.gotmpl
@@ -14,7 +14,7 @@
         {{ .Labels._subject }}
       </h1>
       <div style="line-height: 1.5;">
-				Hi {{ .UserUsername }},
+				<p>Hi {{ .UserUsername }},</p>
         {{ .Labels._body }}
       </div>
       <div style="text-align: center; margin-top: 32px;">

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateTemplateDeleted.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateTemplateDeleted.html.golden
@@ -45,7 +45,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Template "Bobby's Template" deleted
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Hi Bobby,</p>
 
 <p>The template <strong>Bobby&rsquo;s Template</strong> was deleted by <str=

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateTemplateDeprecated.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateTemplateDeprecated.html.golden
@@ -51,7 +51,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Template 'alpha' has been deprecated
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>The template <strong>alpha</strong> has been deprecated with the=
  following message:</p>
 

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateTestNotification.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateTestNotification.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         A test notification
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>This is a test notification.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateUserAccountActivated.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateUserAccountActivated.html.golden
@@ -43,7 +43,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         User account "bobby" activated
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>User account <strong>bobby</strong> has been activated.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateUserAccountCreated.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateUserAccountCreated.html.golden
@@ -43,7 +43,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         User account "bobby" created
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>New user account <strong>bobby</strong> has been created.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateUserAccountDeleted.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateUserAccountDeleted.html.golden
@@ -43,7 +43,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         User account "bobby" deleted
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>User account <strong>bobby</strong> has been deleted.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateUserAccountSuspended.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateUserAccountSuspended.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         User account "bobby" suspended
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>User account <strong>bobby</strong> has been suspended.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/...cations/testdata/rendered-templates/smtp/TemplateUserRequestedOneTimePasscode.html.golden b/...cations/testdata/rendered-templates/smtp/TemplateUserRequestedOneTimePasscode.html.golden
@@ -49,7 +49,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Reset your password for Coder
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>A request to reset the password for your Coder account has been =
 made. Your one-time passcode is:</p>
 

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceAutoUpdated.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceAutoUpdated.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" updated automatically
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your workspace <strong>bobby-workspace</strong> has been updated=
  automatically to the latest template version (1.0).</p>
       </div>

diff --git a/...tifications/testdata/rendered-templates/smtp/TemplateWorkspaceAutobuildFailed.html.golden b/...tifications/testdata/rendered-templates/smtp/TemplateWorkspaceAutobuildFailed.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" autobuild failed
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Automatic build of your workspace <strong>bobby-workspace</stron=
 g> failed.<br>
 The specified reason was &ldquo;<strong>autostart</strong>&rdquo;.</p>

diff --git a/...ications/testdata/rendered-templates/smtp/TemplateWorkspaceBuildsFailedReport.html.golden b/...ications/testdata/rendered-templates/smtp/TemplateWorkspaceBuildsFailedReport.html.golden
@@ -63,7 +63,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace builds failed for template "Bobby First Template"
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Template <strong>Bobby First Template</strong> has failed to bui=
 ld <sup>4</sup>&frasl;<sub>55</sub> times over the last week.</p>
 

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceCreated.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceCreated.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace 'bobby-workspace' has been created
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>The workspace <strong>bobby-workspace</strong> has been created =
 from the template <strong>bobby-template</strong> using version <strong>alp=
 ha</strong>.</p>

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDeleted.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDeleted.html.golden
@@ -46,7 +46,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" deleted
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your workspace <strong>bobby-workspace</strong> was deleted.<br>
 The specified reason was &ldquo;<strong>autodeleted due to dormancy (autobu=
 ild)</strong>&rdquo;.</p>

diff --git a/...ns/testdata/rendered-templates/smtp/TemplateWorkspaceDeleted_CustomAppearance.html.golden b/...ns/testdata/rendered-templates/smtp/TemplateWorkspaceDeleted_CustomAppearance.html.golden
@@ -46,7 +46,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" deleted
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your workspace <strong>bobby-workspace</strong> was deleted.<br>
 The specified reason was &ldquo;<strong>autodeleted due to dormancy (autobu=
 ild)</strong>&rdquo;.</p>

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDormant.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceDormant.html.golden
@@ -51,7 +51,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" marked as dormant
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Hi Bobby,</p>
 
 <p>Your workspace <strong>bobby-workspace</strong> has been marked as <a hr=

diff --git a/...fications/testdata/rendered-templates/smtp/TemplateWorkspaceManualBuildFailed.html.golden b/...fications/testdata/rendered-templates/smtp/TemplateWorkspaceManualBuildFailed.html.golden
@@ -45,7 +45,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" manual build failed
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>A manual build of the workspace <strong>bobby-workspace</strong>=
  using the template <strong>bobby-template</strong> failed (version: <stron=
 g>bobby-template-version</strong>).<br>

diff --git a/...tifications/testdata/rendered-templates/smtp/TemplateWorkspaceManuallyUpdated.html.golden b/...tifications/testdata/rendered-templates/smtp/TemplateWorkspaceManuallyUpdated.html.golden
@@ -47,7 +47,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace 'bobby-workspace' has been manually updated
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>A new workspace build has been manually created for your workspa=
 ce <strong>bobby-workspace</strong> by <strong>bobby</strong> to update it =
 to version <strong>alpha</strong> of template <strong>bobby-template</stron=

diff --git a/...fications/testdata/rendered-templates/smtp/TemplateWorkspaceMarkedForDeletion.html.golden b/...fications/testdata/rendered-templates/smtp/TemplateWorkspaceMarkedForDeletion.html.golden
@@ -48,7 +48,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Workspace "bobby-workspace" marked for deletion
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Hi Bobby,</p>
 
 <p>Your workspace <strong>bobby-workspace</strong> has been marked for <str=

diff --git a/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfDisk.html.golden b/coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfDisk.html.golden
@@ -43,7 +43,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Your workspace "bobby-workspace" is low on volume space
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Volume <strong><code>/home/coder</code></strong> is over 90% ful=
 l in workspace <strong>bobby-workspace</strong>.</p>
       </div>

diff --git a/...s/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfDisk_MultipleVolumes.html.golden b/...s/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfDisk_MultipleVolumes.html.golden
@@ -47,7 +47,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Your workspace "bobby-workspace" is low on volume space
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>The following volumes are nearly full in workspace <strong>bobby=
 -workspace</strong></p>
 

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfMemory.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceOutOfMemory.html.golden
@@ -44,7 +44,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Your workspace "bobby-workspace" is low on memory
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your workspace <strong>bobby-workspace</strong> has reached the =
 memory usage threshold set at <strong>90%</strong>.</p>
       </div>

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateYourAccountActivated.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateYourAccountActivated.html.golden
@@ -43,7 +43,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Your account "bobby" has been activated
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your account <strong>bobby</strong> has been activated.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">

diff --git a/...d/notifications/testdata/rendered-templates/smtp/TemplateYourAccountSuspended.html.golden b/...d/notifications/testdata/rendered-templates/smtp/TemplateYourAccountSuspended.html.golden
@@ -41,7 +41,7 @@ argin: 8px 0 32px; line-height: 1.5;">
         Your account "bobby" has been suspended
       </h1>
       <div style=3D"line-height: 1.5;">
-				Hi bobby,
+				<p>Hi bobby,</p>
         <p>Your account <strong>bobby</strong> has been suspended.</p>
       </div>
       <div style=3D"text-align: center; margin-top: 32px;">