Skip to content

fix: fix IsGithubDotComURL check #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

fix: fix IsGithubDotComURL check #17022

merged 1 commit into from
Mar 20, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented Mar 20, 2025 •
edited
Loading

When DeviceFlow with GitHub OAuth2 is configured, the api.GithubOAuth2Config.AuthCode is overridden and returns a value that doesn't pass the IsGithubDotComURL check. This PR ensures the original AuthCodeURL method is used instead.

@hugodutka hugodutka requested a review from mafredri March 20, 2025 13:01
mafredri
mafredri approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a comment is all that's needed, thanks for the fix!

@hugodutka hugodutka force-pushed the hugodutka/fix-is-github-dot-com-url-check branch from b08c8c9 to d7ba6c0 Compare March 20, 2025 13:14
@hugodutka hugodutka enabled auto-merge (squash) March 20, 2025 13:15
@hugodutka hugodutka merged commit 8d5e6f3 into main Mar 20, 2025
30 checks passed
@hugodutka hugodutka deleted the hugodutka/fix-is-github-dot-com-url-check branch March 20, 2025 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@hugodutka hugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugodutka @mafredri