Skip to content

ci: standardize on go 1.22.12 #17047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2025
Merged

ci: standardize on go 1.22.12 #17047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d98d3e8
chore(dogfood/coder/Dockerfile): revert bump of Go version in dogfood…
johnstcn Mar 21, 2025
fe48124
go1.22.12
johnstcn Mar 24, 2025
ab45772
chore(dogfood/coder): install rust deps from apt when possible
johnstcn Mar 24, 2025
d0c9cf8
chore(dogfood/coder): remove unused go-fuzz dependency
johnstcn Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dogfood/coder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ FROM rust:slim@sha256:9abf10cc84dfad6ace1b0aae3951dc5200f467c593394288c11db1e17b
# Install rust helper programs
# ENV CARGO_NET_GIT_FETCH_WITH_CLI=true
ENV CARGO_INSTALL_ROOT=/tmp/
RUN cargo install exa bat ripgrep typos-cli watchexec-cli && \
RUN cargo install typos-cli watchexec-cli && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: bat was failing to build for me locally, but bat, exa, and ripgrep can now be installed via apt.

# Reduce image size.
rm -rf /usr/local/cargo/registry

FROM ubuntu:jammy@sha256:0e5e4a57c2499249aafc3b40fcd541e9a456aab7296681a3994d631587203f97 AS go

# Install Go manually, so that we can control the version
ARG GO_VERSION=1.24.1
ARG GO_VERSION=1.22.12

# Boring Go is needed to build FIPS-compliant binaries.
RUN apt-get update && \
Expand Down Expand Up @@ -65,9 +65,6 @@ RUN apt-get update && \
# we're using for the version of go-critic that it embeds, then check
# the version of ruleguard in go-critic for that tag.
go install github.com/quasilyte/go-ruleguard/cmd/ruleguard@v0.3.13 && \
# go-fuzz for fuzzy testing. they don't publish releases so we rely on latest.
go install github.com/dvyukov/go-fuzz/go-fuzz@latest && \
go install github.com/dvyukov/go-fuzz/go-fuzz-build@latest && \
Comment on lines -68 to -70
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review: this was failing to build with a tools dependency issue but it doesn't seem to be required since go 1.18?

# go-releaser for building 'fat binaries' that work cross-platform
go install github.com/goreleaser/goreleaser@v1.6.1 && \
go install mvdan.cc/sh/v3/cmd/shfmt@v3.7.0 && \
Expand Down Expand Up @@ -128,6 +125,7 @@ RUN apt-get update --quiet && apt-get install --yes \
asciinema \
bash \
bash-completion \
bat \
bats \
bind9-dnsutils \
build-essential \
Expand All @@ -140,6 +138,7 @@ RUN apt-get update --quiet && apt-get install --yes \
docker-ce \
docker-ce-cli \
docker-compose-plugin \
exa \
fd-find \
file \
fish \
Expand Down Expand Up @@ -176,6 +175,7 @@ RUN apt-get update --quiet && apt-get install --yes \
postgresql-16 \
python3 \
python3-pip \
ripgrep \
rsync \
screen \
shellcheck \
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/coder/coder/v2

go 1.22.9
go 1.22.12

// Required until a v3 of chroma is created to lazily initialize all XML files.
// None of our dependencies seem to use the registries anyways, so this
Expand Down
Loading