fix(cli): replace $SESSION_TOKEN placeholder for external apps #17048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 21, 2025
| // strings in the URL with the actual session token. | ||
| // This is consistent behaviour with the frontend. See: site/src/modules/resources/AppLink/AppLink.tsx | ||
| func replacePlaceholderExternalSessionTokenString(client *codersdk.Client, appURL string) string { | ||
| if !strings.Contains(appURL, "$SESSION_TOKEN") { |
There was a problem hiding this comment.
Is this the only supported format? Not e.g. ${SESSION_TOKEN}?
There was a problem hiding this comment.
Nope, it's just const magicTokenString = "$SESSION_TOKEN";
| return appURL | ||
| } | ||
|
|
||
| // We will just re-use the existing session token we're already using. |
There was a problem hiding this comment.
I think this is fine for apps. For VS Code I think we generate a new one but since it’s long-lived in the editor, it makes sense to decouple them. Same doesn’t apply here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight in #17032
The FE has logic to replace the string
$SESSION_TOKENwith a newly-minted session token.This adds corresponding logic to the
coder open appcommand.