feat(cli): support opening devcontainers in vscode #17189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de4e8ca to
c29d517
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for opening development containers in VS Code via the CLI. Key changes include:
- Updating the CLI documentation to include a new flag (-c, --container) for specifying the container name.
- Adding tests to cover various scenarios for opening VS Code in dev container mode.
- Updating the CLI command implementation to handle container-based logic and URL link generation for dev containers.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/reference/cli/open_vscode.md | Added documentation for the new container flag. |
| cli/open_test.go | Introduced new tests for dev container support and behavior. |
| cli/open.go | Implemented container flag handling and URL building tailored for dev containers. |
Files not reviewed (1)
- cli/testdata/coder_open_vscode_--help.golden: Language not supported
Comments suppressed due to low confidence (1)
cli/open.go:145
- Consider including the specified container name in the error message (e.g., 'no container found matching ') for improved clarity.
if (!foundContainer) {
fe73989 to
e8479f6
Compare
e8479f6 to
9cc49f8
Compare
johnstcn
approved these changes
Apr 3, 2025
cli/open.go
Outdated
Comment on lines
131
to
133
| if !ok { | ||
| return xerrors.New("container missing `devcontainer.local_folder` label") | ||
| } |
There was a problem hiding this comment.
This shouldn't happen in theory, but no harm to check.
- Invert an if-condition to reduce how nested the code was. - Hide `-c` flag for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16427
Adds the option
-c,--containertoopen vscodethat allows opening VSCode into a running devcontainer.