Skip to content

feat(cli): support opening devcontainers in vscode #17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2025
+469 −18
Merged

feat(cli): support opening devcontainers in vscode #17189

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3735e7e
feat(cli): support opening devcontainers in vscode
DanielleMaywood Apr 1, 2025
3632b1b
chore: run 'make gen'
DanielleMaywood Apr 1, 2025
ad6ddca
chore: ensure we use unix path
DanielleMaywood Apr 1, 2025
a1e95e8
chore: fix oopsie on test
DanielleMaywood Apr 1, 2025
f499bb1
chore: muppet
DanielleMaywood Apr 1, 2025
8abf883
chore: filepath from slash
DanielleMaywood Apr 1, 2025
9cc49f8
chore: run test on linux only
DanielleMaywood Apr 1, 2025
93bf7b7
chore: suggestions
DanielleMaywood Apr 3, 2025
e63db0c
chore: replace windowsToUnixPath with filepath.ToSlash
DanielleMaywood Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: replace windowsToUnixPath with filepath.ToSlash
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Apr 3, 2025
commit e63db0c75f9478ba0b54a3ba381fb1aab80e3ee8
6 changes: 1 addition & 5 deletions cli/open.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ func buildVSCodeWorkspaceDevContainerLink(
containerName string,
containerFolder string,
) (*url.URL, url.Values) {
containerFolder = windowsToUnixPath(containerFolder)
containerFolder = filepath.ToSlash(containerFolder)

qp := url.Values{}
qp.Add("url", clientURL)
Expand Down Expand Up @@ -525,10 +525,6 @@ func unixToWindowsPath(p string) string {
return strings.ReplaceAll(p, "/", "\\")
}

func windowsToUnixPath(p string) string {
return strings.ReplaceAll(p, "\\", "/")
}

// resolveAgentAbsPath resolves the absolute path to a file or directory in the
// workspace. If the path is relative, it will be resolved relative to the
// workspace's expanded directory. If the path is absolute, it will be returned
Expand Down
Loading