Skip to content

feat: log long-lived connections acceptance #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Apr 8, 2025
Merged

feat: log long-lived connections acceptance #17219

merged 40 commits into from
Apr 8, 2025
+351 −24

Conversation

ibetitsmike
Copy link
Contributor

Closes #16904

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

ibetitsmike
ibetitsmike commented Apr 2, 2025
View reviewed changes
deansheather
deansheather reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ibetitsmike
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull request Apr 3, 2025
@cdrci2
@ibetitsmike has signed the CLA in coder/coder#17219
7225f27
@ibetitsmike ibetitsmike changed the title Adding logging of opened websocket connections feat: added logging of long lived connections when accepted by the server Apr 3, 2025
@ibetitsmike ibetitsmike marked this pull request as ready for review April 3, 2025 11:46
@ibetitsmike ibetitsmike changed the title feat: added logging of long lived connections when accepted by the server feat: log long-lived connections acceptance Apr 3, 2025
deansheather
deansheather reviewed Apr 3, 2025
View reviewed changes
@ibetitsmike ibetitsmike force-pushed the mike/16904-request-logging-on-long-lived-connection-opening branch from 3a16aad to 817b733 Compare April 6, 2025 23:08
deansheather
deansheather reviewed Apr 7, 2025
View reviewed changes
ibetitsmike added 17 commits April 7, 2025 09:45
@ibetitsmike
initial implementation of RequestLoggerContext and example usage in P…
0e397ed 
…rovisionerJobs logs
@ibetitsmike
fix empty RequestLoggerContext
c384706
@ibetitsmike
referenced httplog while creating RequestLoggerContext
686f4db
@ibetitsmike
refactored fields extension on the logger
7edb8c3
@ibetitsmike
fixed log formatting
5feb4e4
@ibetitsmike
typo comment fix
7500ef5
@ibetitsmike
added logging to long lived connection opening functions
66e2c3e
@ibetitsmike
added logging to other places
4e5f36e
@ibetitsmike
updated comments
b7822b3
@ibetitsmike
renamed context fetcher
a772430
@ibetitsmike
refactored logging in the logger middleware and added tests for logger
2a1dbe3
@ibetitsmike
removed unecessary helpers
5a0fa05
@ibetitsmike
added test for an http request
30bb53d
@ibetitsmike
linting fixes
89e987e
@ibetitsmike
added handling of internal test circumventing RequestLoggerContext in…
1649116 
…jection path
@ibetitsmike
reverted the original behavior of logging WARN on Status Code >=500
7ea2dd6
@ibetitsmike
refactored logger to remove extending it with fields permanently
338fd20
@ibetitsmike ibetitsmike force-pushed the mike/16904-request-logging-on-long-lived-connection-opening branch from 7bb4450 to 09e46d0 Compare April 7, 2025 09:45
deansheather
deansheather approved these changes Apr 8, 2025
View reviewed changes
@ibetitsmike ibetitsmike enabled auto-merge (squash) April 8, 2025 08:05
@ibetitsmike ibetitsmike merged commit ce22de8 into main Apr 8, 2025
35 of 37 checks passed
@ibetitsmike ibetitsmike deleted the mike/16904-request-logging-on-long-lived-connection-opening branch April 8, 2025 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@ibetitsmike
Copy link
Contributor Author

/cherry-pick release/2.19

@ibetitsmike
Copy link
Contributor Author

/cherry-pick release/2.20

@ibetitsmike
Copy link
Contributor Author

/cherry-pick release/2.21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ibetitsmike ibetitsmike

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long-lived requests (websockets, SSE) should log request as soon as they start to block
2 participants
@ibetitsmike @deansheather